Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gnss base topic name #10

Merged
merged 3 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .github/workflows/ros-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,16 @@ jobs:
ros_version: 2

# Rolling Ridley (No End-Of-Life)
# - docker_image: ubuntu:noble
# ros_distribution: rolling
# ros_version: 2
- docker_image: ubuntu:noble
ros_distribution: rolling
ros_version: 2

container:
image: ${{ matrix.docker_image }}

steps:
- name: Checkout
run: |
apt-get -y update
apt-get -y install git
git clone https://github.com/$GITHUB_REPOSITORY.git --recursive "$GITHUB_WORKSPACE"
- name: Checkout source code
uses: actions/checkout@v3

- name: setup ROS environment
uses: ros-tooling/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion mrpt_sensor_gnss_nmea/src/mrpt_sensor_gnss_nmea_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void process_gps(

auto& pubs = NMEA_Pubs::Instance();

pubs.ensure_pubs_are_created(node, publish_topic_);
pubs.ensure_pubs_are_created(node, node.publish_topic());

std_msgs::msg::Header msgHeader;
msgHeader.frame_id = node.sensor_frame_id();
Expand Down
1 change: 1 addition & 0 deletions mrpt_sensorlib/include/mrpt_sensorlib/mrpt_sensorlib.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class GenericSensorNode : public rclcpp::Node
std::shared_ptr<tf2_ros::TransformBroadcaster> tf_bc_;

const auto sensor_frame_id() const { return sensor_frame_id_; }
const auto publish_topic() const { return publish_topic_; }

private:
// ----------------- ROS 2 params -----------------
Expand Down
Loading