-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified gitignore to avoid tracking .DS_Store MacOS files and also r… #2705
base: main
Are you sure you want to change the base?
Conversation
…eplacing unecessary strings with characters types for faster compilations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes. Can you try to fix it everywhere rather than partially? There was an abandoned PR that attempted the same you could pick up and bring over the finish line
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
==========================================
- Coverage 50.74% 0.00% -50.73%
==========================================
Files 392 672 +280
Lines 32553 56718 +24165
Branches 0 7247 +7247
==========================================
- Hits 16517 0 -16517
- Misses 16036 56718 +40682 ☔ View full report in Codecov by Sentry. |
Yes sure, I'll be happy to complete it. |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please break these changes out into two PRs - I'd be happy to approve and merge the .gitignore
change separately from the code changes.
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Fixes a part of #871
Replaced unnecessary strings with characters to make compilation faster.
Also modified the .gitignore file to avoid tracking .DS_Store files which are often generated when working on MacOS systems.