Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRDF disable collision link validity checks #3092

Open
rr-tom-noble opened this issue Nov 15, 2024 · 4 comments
Open

SRDF disable collision link validity checks #3092

rr-tom-noble opened this issue Nov 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@rr-tom-noble
Copy link
Contributor

rr-tom-noble commented Nov 15, 2024

Is your feature request related to a problem? Please describe.

I made a mistake in our SRDF some time ago by disabling collisions using the corresponding tag with a link name that contained a typo. The SRDF loaded fine and (although I didn't get a chance to test collisions) I imagine the ACO will not have reflected the expected configuration.

Describe the solution you'd like

It seems like we could catch these issues when parsing the SRDF by checking that all links mentioned have already been defined in the URDF. This could either throw an error or, if that seems too extreme, raise a warning that there will be unintended effects.

Describe alternatives you've considered

Proofreading my code better I suppose 😆

Additional context

No response

@rr-tom-noble rr-tom-noble added the enhancement New feature or request label Nov 15, 2024
@rhaschke
Copy link
Contributor

It is desired that you can list objects in the ACO, which are not yet existing as links or collision objects. Thus, at most, an unknown name should raise a warning.

@rr-tom-noble
Copy link
Contributor Author

@rhaschke Thanks for confirming. Given it can represent intended behaviour maybe even just an info would be appropriate?

Something like Disabling collisions with <link> which does not yet exist. If you are not expecting to add this to the scene, there may be a typo?

@TSNoble
Copy link
Contributor

TSNoble commented Nov 16, 2024

@rhaschke Oh actually it looks like these warnings already exist. This issue can probably be closed.

@TSNoble
Copy link
Contributor

TSNoble commented Nov 20, 2024

@rhaschke Sorry to double ping you, but I think this can be closed. I think I was just not observant in noticing the existing warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants