From 3ed418c6e44357471b5a74b7638545488512215b Mon Sep 17 00:00:00 2001
From: CyrilFerlicot <cyril@ferlicot.me>
Date: Sat, 15 Jun 2024 17:34:42 +0200
Subject: [PATCH] Smalltalk: Ensure all stubs are in the model

Currently the parents of the stubs are not in the MooseModel which causes some inconsistances. Here is a fix.

Related to #552
---
 .../ImportStubMethodSpecialTest.class.st           | 14 ++++++++++++++
 .../CandidateListOperator.class.st                 |  9 +++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/src/Moose-SmalltalkImporter-LAN-Tests/ImportStubMethodSpecialTest.class.st b/src/Moose-SmalltalkImporter-LAN-Tests/ImportStubMethodSpecialTest.class.st
index 7f0c1448..c9bdc20a 100644
--- a/src/Moose-SmalltalkImporter-LAN-Tests/ImportStubMethodSpecialTest.class.st
+++ b/src/Moose-SmalltalkImporter-LAN-Tests/ImportStubMethodSpecialTest.class.st
@@ -29,3 +29,17 @@ ImportStubMethodSpecialTest >> testStubMethodCreation [
 	self denyEmpty: (model allMethods select: #isStub).
 	self denyEmpty: model allModelMethods
 ]
+
+{ #category : #tests }
+ImportStubMethodSpecialTest >> testStubParentsAreInMooseModel [
+
+	| method class |
+	method := model entityNamed: #'Smalltalk::False.ifTrue:(Object)'.
+	self assert: method mooseModel isNotNil.
+	self assert: method isStub.
+
+	class := method parentType.
+	self assert: class name equals: 'False'.
+	self assert: class mooseModel isNotNil.
+	self assert: class isStub
+]
diff --git a/src/Moose-SmalltalkImporter/CandidateListOperator.class.st b/src/Moose-SmalltalkImporter/CandidateListOperator.class.st
index 8cf5b874..b996efd5 100644
--- a/src/Moose-SmalltalkImporter/CandidateListOperator.class.st
+++ b/src/Moose-SmalltalkImporter/CandidateListOperator.class.st
@@ -14,12 +14,13 @@ Class {
 { #category : #running }
 CandidateListOperator >> allCandidatesFor: invocation [
 
-	^ Array withAll: (groups at: invocation signature ifAbsent: [ 
+	^ Array withAll: (groups at: invocation signature ifAbsent: [
 			   | stubs |
-			   stubs := self importer ensureSmalltalkStubMethodsFor:
-				            invocation signature.
+			   stubs := self importer ensureSmalltalkStubMethodsFor: invocation signature.
 			   groups at: invocation signature put: stubs.
-			   stubs do: [ :each | model add: each ].
+			   stubs do: [ :each |
+				   model add: each.
+				   each allParents do: [ :parent | parent mooseModel = model ifFalse: [ model add: parent ] ] ].
 			   stubs ])
 ]