Merge pull request #68 from moosetechnology/61-PUComment-should-not-e…

…xist removed PUComment in generator + re-generated meta-model
moosetechnology · Jun 20, 2024 · 6eeb690 · 6eeb690
2 parents 4486cd2 + 324d1ab
commit 6eeb690
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 80 deletions.
diff --git a/src/Famix-Fortran77-Entities/FamixF77ImportingContext.class.st b/src/Famix-Fortran77-Entities/FamixF77ImportingContext.class.st
@@ -85,13 +85,6 @@ FamixF77ImportingContext >> importPUBlockdata [
 	^ self importConcreteEntity: (self class fm3ClassNamed: #PUBlockdata)
 ]
 
-{ #category : #importing }
-FamixF77ImportingContext >> importPUComment [
-
-	<generated>
-	^ self importConcreteEntity: (self class fm3ClassNamed: #PUComment)
-]
-
 { #category : #importing }
 FamixF77ImportingContext >> importPUFunction [
 
@@ -260,13 +253,6 @@ FamixF77ImportingContext >> shouldImportPUBlockdata [
 	^ self shouldImport: #PUBlockdata
 ]
 
-{ #category : #testing }
-FamixF77ImportingContext >> shouldImportPUComment [
-
-	<generated>
-	^ self shouldImport: #PUComment
-]
-
 { #category : #testing }
 FamixF77ImportingContext >> shouldImportPUFunction [
 

diff --git a/src/Famix-Fortran77-Entities/FamixF77PUComment.class.st b/src/Famix-Fortran77-Entities/FamixF77PUComment.class.st
diff --git a/src/Famix-Fortran77-Entities/FamixF77ProgramFile.class.st b/src/Famix-Fortran77-Entities/FamixF77ProgramFile.class.st
@@ -13,6 +13,7 @@ a fortran file
 ### Children
 | Relation | Origin | Opposite | Type | Comment |
 |---|
+| `comments` | `FamixTWithComments` | `commentedEntity` | `FamixTComment` | List of comments for the entity|
 | `programUnits` | `FamixF77ProgramFile` | `programFile` | `FamixF77ProgramUnit` | |
 
 ### Other
@@ -35,8 +36,8 @@ a fortran file
 Class {
 	#name : #FamixF77ProgramFile,
 	#superclass : #FamixF77NamedEntity,
-	#traits : 'FamixTCompilationUnit + (FamixTSourceEntity - {#sourceText}) + TEntityMetaLevelDependency',
-	#classTraits : 'FamixTCompilationUnit classTrait + FamixTSourceEntity classTrait + TEntityMetaLevelDependency classTrait',
+	#traits : 'FamixTCompilationUnit + (FamixTSourceEntity - {#sourceText}) + FamixTWithComments + TEntityMetaLevelDependency',
+	#classTraits : 'FamixTCompilationUnit classTrait + FamixTSourceEntity classTrait + FamixTWithComments classTrait + TEntityMetaLevelDependency classTrait',
 	#instVars : [
 		'#filename => FMProperty',
 		'#programUnits => FMMany type: #FamixF77ProgramUnit opposite: #programFile',

diff --git a/src/Famix-Fortran77-Entities/FamixF77TEntityCreator.trait.st b/src/Famix-Fortran77-Entities/FamixF77TEntityCreator.trait.st
@@ -88,13 +88,6 @@ FamixF77TEntityCreator >> newPUBlockdata [
 	^ self add: FamixF77PUBlockdata new
 ]
 
-{ #category : #'entity creation' }
-FamixF77TEntityCreator >> newPUComment [
-
-	<generated>
-	^ self add: FamixF77PUComment new
-]
-
 { #category : #'entity creation' }
 FamixF77TEntityCreator >> newPUFunction [
 

diff --git a/src/Famix-Fortran77-Generator/FamixFortran77Generator.class.st b/src/Famix-Fortran77-Generator/FamixFortran77Generator.class.st
@@ -40,7 +40,6 @@ Class {
 		'parameter',
 		'programUnit',
 		'puBlockdata',
-		'puComment',
 		'puFunction',
 		'puMain',
 		'puProcedure',
@@ -149,10 +148,6 @@ FamixFortran77Generator >> defineClasses [
 		               newClassNamed: #PUBlockdata
 		               comment: self puBlockdataEntityComment.
 
-	puComment := builder
-		             newClassNamed: #PUComment
-		             comment: self puCommentEntityComment.
-
 	puFunction := builder
 		              newClassNamed: #PUFunction
 		              comment: self puFunctionEntityComment.
@@ -222,6 +217,7 @@ FamixFortran77Generator >> defineHierarchy [
 
 	programFile --|> namedEntity.
 	programFile inheritsFromTrait: #TSourceEntity without: { #sourceText }.
+	programFile --|> #TWithComments.
 	programFile --|> #TCompilationUnit.
 	programFile --|> #TEntityMetaLevelDependency.
 
@@ -234,9 +230,6 @@ FamixFortran77Generator >> defineHierarchy [
 	puBlockdata --|> programUnit.
 	"puBlockdata --|> #TWithTypes."
 
-	puComment --|> programUnit.
-	puComment --|> #TComment.
-
 	puFunction --|> puProcedure.
 	puFunction --|> #TTypedEntity.
 
@@ -427,12 +420,6 @@ FamixFortran77Generator >> puBlockdataEntityComment [
 	^ 'a block data for common variable'
 ]
 
-{ #category : #'class comment' }
-FamixFortran77Generator >> puCommentEntityComment [
-
-	^ 'a comment belongs to fortran file'
-]
-
 { #category : #'class comment' }
 FamixFortran77Generator >> puFunctionEntityComment [