feat: added Turkish E layout, fixed word count on Turkish lists and further changed Turkish list (@jirmu) #6068
Conversation
monkeytypegeorge
added
frontend
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
There was a problem hiding this comment.
line 7 ol - olmak
line 18 al - almak (do you mean old Turkish word for red "al" or the verb)
line 21 gel - gelmek
line 23 ver - vermek
line 34 çık - çıkmak
line 35 gör - görmek
line 38 git - gitmek
line 42 bil - bilmek
line 48 bak - bakmak
line 49 çalış - çalışmak
line 53 başla - başlamak
line 55 kal - kalmak
line 59 yapılma - yapılmak
line 65 bulun - bulunmak
line 66 söyle - söylemek
line 68 gerek - gerekmek or alt. suggestion gerekli
line 82 gir - girmek
line 84 ye - yemek
line 92 yaşa - yaşamak
line 93 düşün - düşünmek
line 109 göster - göstermek
line 112 getir - getirmek
line 113 kullan - kullanmak
line 129 konuş - konuşmak
line 131 anla - anlamak
line 142 sor - sormak or alt. suggestion soru
line 146 sağla - sağlamak or alt. suggestion sağlam
line 148 kullanılma - kullanılmak
line 153 dön - dönmek
line 154 aç - açmak
line 156 anlat - anlatmak
line 169 tut - tutmak
line 176 sev - sevmek
line 179 çıkar - çıkarmak
line 185 verilme - verilmek
line 197 bekle - beklemek
There was a problem hiding this comment.
gerekli sounds good, although gerek is already a word as stated in TDK.
There was a problem hiding this comment.
However, the examples stated in 3 of the 4 stated TDK dictionary are taken from literary works. They are inverted sentences. It is either used as gerekli or as a noun phrase "para gerekli". If it is to be used as verb. It is gerekmek.
There was a problem hiding this comment.
Yeah, I agree. i will change it to gerekli now.
There was a problem hiding this comment.
What is the reason for removing these words?
There was a problem hiding this comment.
they are removed so that the corpuses have the same amount of words as they claim to have as stated in the contributing guidelines markdown file (turkish is 200, turkish 1k is 1000 and turkish 5k is 5000 words).
There was a problem hiding this comment.
Not all 5K language files have exact 5K words in them. You are removing 0.6% of the words from 5K list. That is unnecessary.
There was a problem hiding this comment.
elaborated as reply to the 1k file change.
There was a problem hiding this comment.
What is the reason for removing these words?
There was a problem hiding this comment.
same reason as the comment i left about turkish 5k.
There was a problem hiding this comment.
Exactly the same as before. Not all 1K language files have exact 1K words in them. How does this edit improves anything?
There was a problem hiding this comment.
I have never claimed it was an improvement. this post is tagged as a feature add and the main highlight is the addition of the Turkish E layout. this is just a very small adjustment and it neither hurts anyone nor is againdt the rules. i have shoved them around with the layout add because i thought that this very small change ( less than a percent actually as you claimed) would be too small to make a pr by its own.
|
It is indeed my native language. I am living in Türkiye right now, İstanbul to be more specific. i have elaborated on the removal of the words in the comments of the turkish 1k file change. |
There was a problem hiding this comment.
I hope you are aware your skill in your native language is abysmal. You had no problem committing words like "görül", "kullanıl", etc... In university classes I recommend this website to the students so they can improve their typing skills. So they wouldn't fail in their exams because they lack the speed to type the required codes and texts etc. Your "fixes" don't help the general audience using this website, on the contrary.
Oh well, no point in trying to convince you. i will close the commit. you can make a pr to get the changes you want added back to master branch. |
I have no pr in this. This is the only site I am committing, and only thing I care is this website is usable to me and I can direct students to improve their skills in typing. I had courses in touch typing but students are not that lucky. You have already made a horrible commit previously. I don't see any fix to your previous mistake and I see nothing improved. |
i think you misunderstood me. by pr i meant pull request. you can open one of these pull requests yourself to fix the issues (or, revert them rather) or i can fix them for you if you dont have the time to deal with it or simply dont want to bother. i apologize if i sounded harsh by accident there. |
|
I will be opening a new pull request tomorrow about adding the Turkish E layout and reverting the previously changed corpora back to normal if you want me to. I am sorry if any of your students caused you trouble at the meantime about the site. Have a good evening. |
|
You are probably more skilled than me in IT matters. You see, I haven’t thought of pr as pull request. I am no longer doing IT work, it has been years. You haven’t sounded harsh there is nothing to apologize. I might be harsh one here, because I was really frustrated when I saw the changes made in turkish.json. And you were not improving them in any way. Conflicts happen in life and we talk through them.
When you are exercising finger positions and keystrokes, the words don’t matter. They should be gibberish, whole point should be to memorize key locations and finger combinations. However, when you are exercising to type accurately and fast, you read the next word and even two words while you type. If the next word is misspelled, or if it is a rare conjugated form of a verb, esoteric to a certain profession it throws the writer off. It ruins the typing experience. The choice of words is not always science, there is always a bit of art in it. Just, because it is in a dictionary doesn't make it the right word.
I am looking forward to practice Turkish E layout myself. It is a valuable contribution. Thank you sincerely.
… On 23 Nov 2024, at 19:14, jirmu ***@***.***> wrote:
I will be opening a new pull request tomorrow about adding the Turkish E layout and reverting the previously changed corpora back to normal if you want me to. I am sorry if any of your students caused you trouble at the meantime about the site. Have a good evening.
—
Reply to this email directly, view it on GitHub <#6068 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AISUMDLBTMRUL2CASJ4SGQT2CCSVZAVCNFSM6AAAAABSK4CFHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVGUZDOMBXGY>.
You are receiving this because you commented.
|
I see. I do suggest you that you be careful as learning a new keyboard layout can take a little while, and if typing fast is something you depend on as your job it could be risky since you need to spend about anywhere between 5 to 30 minutes of practice a day to get to reach decent speeds, in my own experience it took me around a month to reach 60 words per minute with the aforementioned amount of practice. Although Turkish E is a relatively good layout, it is made with little thought in mind and is outdated, as there have been new advancements found while developing layouts made for English and other languages (many of which also applicable to all languages including Turkish). I have made a new pull request about only adding the Turkish E layout a moment ago and have asked the developer of the site myself to remove the previously merged changes. I apologize again for the frustration caused, and wish you a good evening. |
Description
Checks
- Adding quotes?
- Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
- Adding a language or a theme?
- If is a language, did you edit
- If is a theme, did you add the theme.css?
- Also please add a screenshot of the theme, it would be extra awesome if you do so!
- Check if any open issues are related to this PR; if so, be sure to tag them below.
- Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
- Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
@jirmu_list.json,_groups.jsonand addlanguages.json?Closes #
further tweaked the Turkish list to add change the words currently making no sense as stated in a previous pull request, now they have an extra suffix and are the version they can be found in dictionaries like TDK. added Turkish E layout (referred also as "E Klavye") created by TÜBİTAK in 2012. changed the amount of words so that the lists now have the correct amount of words they claim to have (turkish.json especially had 298, needed to be brought down to 200.) This is a continuation of pr #6046.