-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chinese quotes treated as a single word #5358
Comments
If that can be fixed, I believe the spaces in the "words" section should be typed automatically too, as a sentence in Simplified Chinese does not include spaces. |
i reckon you keep the words the same, it’s good to separate the words but just count every character in a sentence as a word in the quotes section |
The characters used are full-width commas, and as @faq0 said, simplified chinese does not include spaces, so im not sure what should be done here. |
the punctuation isn't an issue, there isn't much punctuation in the quotes anyways, i reckon you can count every character as a word and parse out the full width punctuation or change it into its english equivalent when counting the words although this would be rough to implement. it's really up to you, but as a quasi-mandarin speaker this is just my suggestion. |
So, whats the solution? Because if you want to add spaces you would need to edit the quotes themselves. |
wdym, i’m saying we count each character as a word, as mandarin doesn’t follow the rule that each word is separated by spaces. eg. “猴子打字” (monkey type lol) counted as 4 separate words |
also if we add spaces it wouldn’t be accurate, not sure how the word counting works but a special case can be added to split the characters differently (removing the punctuation before of course) |
So, this should be the case for all chinese text, not just quotes right. Is this because you need multiple keypresses per character? Maybe we can count each keypress as a character, instead of each character as a word. |
Yes.
This would be good in most cases, but I believe that could be the way to calculate the speed, not the accuracy. e.g.: For an example quote "我能吞下玻璃而不伤身体", |
yes i agree with faq0 on the speed calculation part but the main issue is that in the quotes the entire sentence is counted as one word, i’m suggesting that we split the quote by character instead of by space as when someone presses space the test ends and the progress is inaccurate |
If you split by character then the website will require you to press space between every chracter. When you type quotes normally, when do you press space? (not on monkeytype). |
in chinese there is no such thing as a space lol |
What if i just disable space then? Monkeytype wont try to "move to the next word" because there would be no "next word" and that "moving to the next word" wont even be triggered by the space. The only thing the space would be doing is interacting with the input manager, like it already does. |
what does this mean? |
this should be good enough haha |
Keystroke per second is calculated based on the number of keystrokes, which will be shown on the final speed chart, while the accuracy and WPM is calculated based on the typed Chinese characters per second. |
This should be a good idea, as long as it can deal with the speed and accuracy correctly. |
another problem might be that 1 misspelt character results in the test being unable to finish, as when u disable space, it will stop the test from force finishing as monkeytype does not let you finish on a misspelt word. |
im pretty sure you have to both split quote by character and disable spaces |
i've done some thinking and this problem is present in nearly all text input based websites: here
https://docs.rws.com/791662/251856/sdl-worldserver-11-0-1/word-counting-algorithm the best way, imo, is to count every character as a word, remove "spaces" when presenting input to user, and auto-nextword when they type a character is there a way to auto-nextword? where is the code to handle next words in the file system? |
@extoplasm Which languages should use this per character way of calculating speed? |
Also, are the calculated speeds accurate if you just change the typing speed unit to cpm in the settings? |
japanese and chinese off the top of my head
not sure can’t test rn i’m not at home |
is that my bad... oops |
PR added. Added some quotes as well. #5465 |
Looking at the data, it looks like you're reporting less keypresses than characters typed. Looks like the input system is eating up some of the keypress events (which seems to be the same issue as someone else just opened with Korean typing..) |
Did you clear cache before opening an issue?
Is there an existing issue for this?
Does the issue happen when logged in?
Yes
Does the issue happen when logged out?
Yes
Does the issue happen in incognito mode when logged in?
Yes
Does the issue happen in incognito mode when logged out?
Yes
Account name
extoplasm
Account config
{"theme":"alduin","themeLight":"serika","themeDark":"serika_dark","autoSwitchTheme":false,"customTheme":false,"customThemeColors":["#323437","#e2b714","#e2b714","#646669","#000000","#d1d0c5","#ca4754","#7e2a33","#ca4754","#7e2a33"],"favThemes":[],"showKeyTips":true,"smoothCaret":"medium","quickRestart":"off","punctuation":false,"numbers":false,"words":10,"time":60,"mode":"quote","quoteLength":[0],"language":"chinese_simplified","fontSize":1.5,"freedomMode":true,"difficulty":"normal","blindMode":false,"quickEnd":false,"caretStyle":"default","paceCaretStyle":"default","flipTestColors":false,"layout":"default","funbox":"none","confidenceMode":"off","indicateTypos":"off","timerStyle":"mini","liveSpeedStyle":"off","liveAccStyle":"off","liveBurstStyle":"off","colorfulMode":false,"randomTheme":"off","timerColor":"main","timerOpacity":"1","stopOnError":"off","showAllLines":false,"keymapMode":"off","keymapStyle":"staggered","keymapLegendStyle":"lowercase","keymapLayout":"qwerty","keymapShowTopRow":"layout","fontFamily":"JetBrains_Mono","smoothLineScroll":false,"alwaysShowDecimalPlaces":false,"alwaysShowWordsHistory":false,"singleListCommandLine":"manual","capsLockWarning":true,"playSoundOnError":"off","playSoundOnClick":"9","soundVolume":"1.0","startGraphsAtZero":true,"showOutOfFocusWarning":true,"paceCaret":"pb","paceCaretCustomSpeed":1,"repeatedPace":true,"accountChart":["on","on","on","on"],"minWpm":"off","minWpmCustomSpeed":100,"highlightMode":"letter","typingSpeedUnit":"wpm","ads":"result","hideExtraLetters":false,"strictSpace":false,"minAcc":"off","minAccCustom":90,"monkey":false,"repeatQuotes":"off","oppositeShiftMode":"off","customBackground":"","customBackgroundSize":"cover","customBackgroundFilter":[0,1,1,1,1],"customLayoutfluid":"qwerty#dvorak#colemak","monkeyPowerLevel":"off","minBurst":"off","minBurstCustomSpeed":100,"burstHeatmap":true,"britishEnglish":false,"lazyMode":false,"showAverage":"off","tapeMode":"off","maxLineWidth":0}
Current Behavior
when typing in chinese, entire quote is treated as one word -> whenever space is pressed the test finishes, also every quote is in the short category.
Expected Behavior
could count every character excluding punctuation as a word
Steps To Reproduce
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: