feat(icon): add brand visuals icons to icon component #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheffauer
requested changes
Oct 9, 2024
| @@ -95,6 +95,7 @@ | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.0.0", | |||
| "@momentum-design/animations": "^0.0.4", | |||
| "@momentum-design/brand-visuals": "^0.0.24", | |||
There was a problem hiding this comment.
brand visuals are different in terms of sizing and color as Icons are - we don't want to use the same component for both. I would recommend to create a separate component if there is a need for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR (#649) notes:
Description
note: the new, larger icons included in the new brand-visuals library will not show correctly with the icons component, but this change should be sufficient for our usage in cantina for now
Links
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-564427