Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Got to v12.x #19

Open
3 tasks
AndreMaz opened this issue Dec 28, 2021 · 2 comments
Open
3 tasks

Update Got to v12.x #19

AndreMaz opened this issue Dec 28, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AndreMaz
Copy link
Member

got, HTTP client that this mixin uses, was recently updated to v12 (release notes are here: https://github.com/sindresorhus/got/releases/tag/v12.0.0). This release has several breaking changes that need to be addressed in order to update the moleculer-http-client.

ToDo list:

  • update the client
  • fix all the tests
  • update the examples
@AndreMaz AndreMaz added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 28, 2021
@icebob
Copy link
Member

icebob commented Dec 29, 2021

By the way, sindresorhus converts all his projects to ESM, so you can't use it with require.

@AndreMaz
Copy link
Member Author

AndreMaz commented Oct 9, 2022

CSJ version is available: https://www.npmjs.com/package/got-cjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icebob @AndreMaz