Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query constructor #111

Open
moigagoo opened this issue Apr 8, 2021 · 1 comment
Open

Query constructor #111

moigagoo opened this issue Apr 8, 2021 · 1 comment

Comments

@moigagoo
Copy link
Owner

moigagoo commented Apr 8, 2021

Norm's select procs work with vanilla WHERE conditions, which you have to write manually. The problem is you have to know which table and column names correspond to which type and attribute names. This is error-prone, fragile in the long run, and all together ugly.

We need a query constructor that would allow the programmer to compose queries in terms of Nim types and object fields.

Instead of db.select(pets, """"Pet".species LIKE $1""", "dog"), I want something like db.select(pets, qry(Pet.species ~ "$1"), "dog") or db.select(pets, qry(Pet.species.like "$1"), "dog") or even db.select(pets, qry(Pet.species ~ "dog"))

@moigagoo moigagoo added this to Norm Jul 22, 2022
@moigagoo moigagoo moved this to To do in Norm Jul 22, 2022
@moigagoo moigagoo removed the status in Norm Jul 22, 2022
@Clonkk
Copy link
Contributor

Clonkk commented Sep 12, 2022

I don't know if this helps, but in my projects i've often used helper procs that look like this :

template newWith[T: Model](t: typedesc[T], dbConn: DbConn, field: static[string], val: untyped) : T =
  var res = new(t)
  let qry = $(t)& "." & field & "=?"
  dbConn.select(res, qry, val)
  res

var dog = Pet.newWith(dbConn, "species", "dog")

If you're not afraid of a bit more "macro" heavy style you can even do :

macro newWith[T: Model](dbConn: DbConn, model: var T, field: untyped, val: untyped) =
  let t = getTypeInst(model)
  result = newStmtList()
  result.add newCall("new", model)
  let errstr = &"Error {model}.{field} does not compile"
  let qry = $(t) & "." & $field & "=?"
  result.add quote do:
    when compiles(`model`.`field`):
      dbConn.select(`model`, `qry`, `val`)
    else:
      {.error: `errstr`.}
  # echo result.repr


var dog : Pet
newWith(dbConn, dog, species, "dog")

Which will check that dog.species compiles and raise a CT error otherwise.

Many variation of API are possible with dog.species parsed as one argument, 2 argument, as static string etc. and all operation & check performed at CT.

Penny for your thoughts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants