Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when the plotting frame is set to MCMF #3872

Closed
kscarvajalc opened this issue Feb 10, 2024 · 7 comments
Closed

Crash when the plotting frame is set to MCMF #3872

kscarvajalc opened this issue Feb 10, 2024 · 7 comments

Comments

@kscarvajalc
Copy link

So, I was trying to land in the Mun but the moment I changed to the surface reference frame the game crashed with a window from Visual C++, the crash happens every time the trajectory intersects with the surface no matter if it is a flight plan, the actual landing or the tracking station.

https://gist.github.com/kscarvajalc/bbc5364f9884ea1b2ceb74a0dd4743c6

@kscarvajalc kscarvajalc changed the title Crash when setting plotting frame to MCMF Crash when the plotting frame is set to MCMF Feb 10, 2024
@pleroy
Copy link
Member

pleroy commented Feb 11, 2024

Thanks for reporting. Do you by any chance have a crash folder in %USERPROFILE%\AppData\Local\Temp\Squad\Kerbal Space Program\Crashes? If so, could you zip it and send it to us?

The journal does indeed indicate a failure in the new impact computation code, but I am unable to reproduce the crash. That may not be too surprising since the problem looks like some kind of memory corruption and these things are hard to reproduce. The crash dump could give us some hints.

@kscarvajalc
Copy link
Author

No, there are no folders related to that crash

@pleroy
Copy link
Member

pleroy commented Feb 13, 2024

If you are able to reproduce the crash, could you give us your KSP.log file immediately after the crash? (Note that this file gets overwritten each time you start the game, so it's important to get the one that corresponds to the crash.)

@kscarvajalc
Copy link
Author

I was able to reproduce the crash, curiously this time the trajectory wasn't suborbital, just very eccentric.

https://gist.github.com/kscarvajalc/3a530b7fc09b536f9e9f7746545324e0

@pleroy
Copy link
Member

pleroy commented May 25, 2024

The files in the latest reply don't contain any crash. We didn't hear about any bug in this code since #3882 and #3959, so I am closing this issue.

@kscarvajalc
Copy link
Author

Hello, I couldn't update the report, the problem persist with the same dialog as the seen in #4038 for all the releases until Klein. Today, I updated the mod, and the crash when the vessel is in suborbital trajectory is solved, but still crashes when the periapsis is close to the ground and the plotting frame is MCMF, with the difference that the game just freezes with no dialog. Also I think the crash happened when I tried to start the engine.

ERROR.20240813-192650.7288.log
WARNING.20240813-192650.7288.log
INFO.20240813-192650.7288.log
JOURNAL.zip
Player.log

Like the last time, there is no crash folder.

@pleroy
Copy link
Member

pleroy commented Aug 15, 2024

(I didn't realize that there was a windows from the C++ Runtime Library in the original report. A screenshot would have been helpful.)

I am marking this issue as a duplicate, let's continue the discussion in #4038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@pleroy @kscarvajalc and others