Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two of the three failing subtests in socket-api-tests #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix two of the three failing subtests in socket-api-tests #8

wants to merge 2 commits into from

Conversation

musicinmybrain
Copy link

Fixes getaddrinfo_valid and getaddrinfo_error when getaddrinfo() offers non-SOCK_STREAM addresses, such as SOCK_DGRAM, for the "ssh" service on localhost.

Fixing create_invalid_sockclient requires more thought; see #7 (comment).

@musicinmybrain
Fix getaddrinfo_valid: ask for SOCK_STREAM
d9de7a6 
Since we test that the results are of type SOCK_STREAM, we need to ask
for that in the hints to getaddrinfo.
@musicinmybrain
Fix getaddrinfo_error: ask for SOCK_RAW
9a9a70b 
Since getaddrinfo may offer results of type SOCK_DGRAM, we ask for
something more difficult (but still a valid socket type).
@musicinmybrain musicinmybrain mentioned this pull request Oct 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@musicinmybrain