Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Missing die test "suspicious_missing_die" #38

Open
jonasstein opened this issue Dec 8, 2017 · 0 comments
Open

FR: Missing die test "suspicious_missing_die" #38

jonasstein opened this issue Dec 8, 2017 · 0 comments

Comments

@jonasstein
Copy link
Contributor

jonasstein commented Dec 8, 2017

Very often || die is missing behind echo to files or sed

For example:
echo '#!/bin/true' >share/genbuild.sh
should be
echo '#!/bin/true' >share/genbuild.sh || die

I think this will be part of a group of tests, which will never be 100% accurate, but remembers the maintainer to double check the line manually.

The following line lists all ebuilds with no die behind echo, while it is likely written to files there
qgrep -Nx "echo .* > " | grep -v die

Should we have a category suspicious for tests which will likely contain many false positives but are worth a verification?

We need the test for

  • echo
  • sed
  • rm
  • cp
  • mv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant