Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested updates support #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Nested updates support #54

wants to merge 4 commits into from

Conversation

Eldow
Copy link
Contributor

@Eldow Eldow commented Jun 29, 2021

@mlipscombe tell me what you think about it. I will provide the tests ASAP.

I'm pretty sure there is a nicer way than includes('updateBy') to detect an updater field in the input but I'm not very used to what's available.

Linked issues :
#29
#53

@francescovenica
Copy link

is this working with infinte nested mutations?

@Eldow
Copy link
Contributor Author

Eldow commented Jul 4, 2021

Yes it should be.

@andrisak
Copy link
Contributor

andrisak commented Aug 4, 2021

@Eldow I'm also interested in getting this merged. There are a couple of existing integration tests that fail. I've fixed that and also added tests (which lead to a few minor changes). I have opened a PR for your fork with those changes. Would you please have a look?

Integration tests for nested mutations support
@Eldow
Copy link
Contributor Author

Eldow commented Aug 5, 2021

Hello @andrisak thanks a lot for your contribution, it looks perfect to me :) Those are definitely relevant changes.

@jsauca
Copy link

jsauca commented Nov 17, 2021

I am really interested by this feature; when will this one be merged ?

@mgagliardo91
Copy link

@mlipscombe Is this repo considered unmaintained now? This seems like a pretty desirable PR and hasn't had any updates since 2021

@jskrable
Copy link

bumping this again, this would be a helpful feature. alternatively, throwing an error or warning instead of silent non-updates would save debugging time.

@francescovenica
Copy link

in the meantime if you want you can try this branch:
https://github.com/francescovenica/postgraphile-plugin-nested-mutations/tree/fix-update-by-key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants