Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic set strides kernels in dynunet #955

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Automatic set strides kernels in dynunet #955

merged 10 commits into from
Oct 9, 2024

Conversation

benmalef
Copy link
Contributor

@benmalef benmalef commented Oct 4, 2024

Fixes #949

Proposed Changes

  • Calculate automatically the kernel and strides for dynunet model
  • Update the tests

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

benmalef and others added 3 commits October 4, 2024 18:53
@benmalef
made some code changes in dynunet_wrapper
6468f12 
- change the spacing -> spacing_for_internal_computations
- change the code to ensure that it only runs through compute when needed
@benmalef
blacked dynunet_wrapper
751325d
@sarthakpati
Merge branch 'master' into dynunet_set_automaticaly_strides_kernels
0fc7fc4
@sarthakpati sarthakpati changed the title Set automaticaly strides kernels in dynunet model Automatic set strides kernels in dynunet Oct 5, 2024
@sarthakpati
Copy link
Collaborator

@benmalef is this good to merge?

@benmalef
update dynunet_wrapper.py
4c3da18 
- change raise ValueError with assert
@benmalef benmalef marked this pull request as ready for review October 7, 2024 07:06
@benmalef benmalef requested a review from a team as a code owner October 7, 2024 07:06
@sarthakpati sarthakpati merged commit bcffff8 into mlcommons:master Oct 9, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
@benmalef benmalef deleted the dynunet_set_automaticaly_strides_kernels branch November 1, 2024 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set automatilacy the numbers of parameters (strides and kernels) in dynunet
2 participants
@benmalef @sarthakpati