Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality related to DP training #945

Merged

Conversation

scap3yvt
Copy link
Collaborator

Fixes #944

Proposed Changes

  • Add DP-enabled training and inference from private repo
  • Most of the code is copy-paste from the private repo, with some added documentation and changes from raised errors to assertions.

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner September 23, 2024 14:18
Copy link
Contributor

github-actions bot commented Sep 23, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati
Copy link
Collaborator

This seems to be okay for me. Any comments, @VukW and @brandon-edwards?

@brandon-edwards
Copy link

This looks reasonable to me as well, but I have not tested it.

@sarthakpati
Copy link
Collaborator

sarthakpati commented Sep 24, 2024

This should not be merged until #947 is merged and the master gets tagged.

@sarthakpati
Copy link
Collaborator

Support ticket generated with Codacy to explore the coverage issue.

@sarthakpati sarthakpati merged commit 2f33623 into mlcommons:master Oct 1, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add DP-enabled training
3 participants