-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] speed up CI tests #835
Comments
It is definitely possible to speed the tests up, but we need to be cognizant about the possibility that it could come at a cost (for instance, in terms of code coverage or test readability). For example, right now, the tests are triaged in terms of data type (rad/histo images), data dimensionality (2d/3d), workload (segmentation/classification/regression). and so on. Some of these can be combined, such as the tests for the schedulers/optimizers can be combined with one of the data types (for e.g., 2d rad), in which case there would be 1 (large) test that would be providing coverage for huge swaths of the code. It would work in terms of code coverage, but would degrade the readability of the testing code. There is definitely a better solution for our testing, though. There is quite a bit of redundancy (multiple rad/histo tests with 2d/3d) where the same part of the code gets traversed. Will definitely need someone with a good QA bent of mind to tackle this. 😉 |
One idea could perhaps be to split each of the test "categories" into separate workflows. This won't reduce the test time for local runs, but it will parallelize the CI for PRs. |
Stale issue message |
Stale issue message |
Stale issue message |
Stale issue message |
Is your feature request related to a problem? Please describe.
Now running all the tests takes around ~30 mins. I understand we run a few training loops (on CPU) during tests; however, maybe it is still possible to speed them up?
Describe the solution you'd like
Crucial is to keep the same tests coverage while tuning tests.
The text was updated successfully, but these errors were encountered: