Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Consumer and BufferedConsumer have the same interface. #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MyGGaN
Copy link
Contributor

@MyGGaN MyGGaN commented Feb 28, 2014

It should be possible to switch between the two consumer classes provided without any code change. Currently you'll run into issues if you have implemented the BufferedConsumer, with calls to flush() where appropriate, and then, for some reason, goes back to the default Consumer.
My suggestion is to simply add a dummy flush() method to Consumer. I made it static since it doesn't use self and it works great with inheritance too.

@zakj zakj self-assigned this Mar 10, 2015
@zakj
Copy link
Contributor

zakj commented Mar 10, 2015

Great point! Thanks for this; we've got some other Consumer changes I need to review but I will be sure this goes out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants