Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-xml-parser dependency has high vulnerabilities #61

Open
b00ga opened this issue Sep 1, 2023 · 2 comments
Open

fast-xml-parser dependency has high vulnerabilities #61

b00ga opened this issue Sep 1, 2023 · 2 comments

Comments

@b00ga
Copy link

b00ga commented Sep 1, 2023

This library is getting installed when I npm install @mitre/saf and npm reports there are vulnerabilities to check. When I run npm audit, it reports the following for this lib's fast-xml-parser dependency:

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ fast-xml-parser vulnerable to Regex Injection via Doctype    │
│               │ Entities                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ fast-xml-parser                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.2.4                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @mitre/saf                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @mitre/saf > @mitre/inspec-objects > fast-xml-parser         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://github.com/advisories/GHSA-6w63-h3fj-q4vw            │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ fast-xml-parser vulnerable to Prototype Pollution through    │
│               │ tag or attribute name                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ fast-xml-parser                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.1.2                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @mitre/saf                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @mitre/saf > @mitre/inspec-objects > fast-xml-parser         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://github.com/advisories/GHSA-x3cc-x39p-42qx            │
└───────────────┴──────────────────────────────────────────────────────────────┘
@b00ga
Copy link
Author

b00ga commented Sep 1, 2023

Looking at this package's package.json, the fast-xml-parser dependency is "^3.1.19", so I can see where that won't pickup a 4.x version of fast-xml-parser. I'm not a JS/node developer, so I don't know how easy a lift it is to go from 3.x to 4.x

I will note however, when I create a packge-lock.json for my @mitre/saf install, @mitre/hdf-converters wants fast-xml-parser "^4.2.0" and @mitre/saf itself wants "^4.2.7". They appear to be using 4.2.7 which is the latest release (https://www.npmjs.com/package/fast-xml-parser?activeTab=versions).

@b00ga
Copy link
Author

b00ga commented Sep 1, 2023

Had not checked PRs, and was just looking and it looks like depend-a-bot tried to apply a merge for this in #45 which is still pending merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant