Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social-auth-core[saml] as a dependency #42

Open
noisecapella opened this issue Jul 13, 2021 · 1 comment
Open

Add social-auth-core[saml] as a dependency #42

noisecapella opened this issue Jul 13, 2021 · 1 comment

Comments

@noisecapella
Copy link

Unless this package is included in projects using ol-django's authentication app, there are some missing packages like onelogin for example. We should include social-auth-core[saml] as an explicit dependency since the authentication code won't work without it. What do you think @rhysyngsun?

@rhysyngsun
Copy link
Collaborator

@noisecapella I think it should probably be an optional dependency, but the auth app should have an opinion about which versions it supports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants