This repository has been archived by the owner on May 13, 2024. It is now read-only.
Upgrade actions in CI #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
two failing appear to be unrelated to changes made in this pr |
|
Not unrelated but this bug was previously hidden. |
could this also be solved by changing https://github.com/minetest/irrlicht/blob/master/.github/workflows/build.yml#L261 to be |
|
Yes. Either works. |
|
in theory fixed (see when tests finish in ... ) |
appgurueu
approved these changes
Feb 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
To do
This PR is a Work in Progress
Outside the scope of just upgrading actions
lukka/run-vcpkg@v7 - minetest/minetest#14377 (comment)
How to test
use your eyes to check actions reports