Reformat the code #248
Reformat the code #248
Conversation
|
Reapplied. |
|
Reapplied. @Desour |
Alignment?
Doing exactly what you suggest is possible but won’t help as great deal of these non-leading tabs wasn’t even legitimate alignment. Up to this sample in include/SMaterialLayer.h. Manually working through that is possible (it’s just 1k lines) but out of scope of this PR. Saying that, now I think that commit wasn’t at all good, due to e.g. code samples in comments. I removed it from the branch as it would be much easier to reapply its good part than to undo its bad part later. |
Yes, I just find it's neat.
I thought more about writing a script that does it.
Good solution for now. 👍 |
find -type f | # list all regular files grep -E '\.(h|cpp|mm)$' | # filter for source files grep -v '/mt_' | # filter out generated files xargs -n 1 -P $(nproc) clang-format -i # reformat everything
|
Reapplied. |
|
I think we should do this as the very last step before importing it into the MT repo since at that point the ability to easily backport upstream commits and all PRs on this repo are lost anyway. |
|
What else holds the import, then? |
|
It has been decided in the last dev meeting, that #276 will be merged first. After that one is merged, we won't trigger another rebase of this PR. |
|
I think we can also use this opportunity to move all files from |
|
@numberZero I've seen you've deleted some of your fork repos. If you don't want to work on this anymore, we'll adopt this. :-) I hope you're doing fine though. |
Included in new PR. |
This is a (hopefully final) prerequisite for minetest/minetest#13642.
I used
.clang-formatfrom Minetest but altered it a bit. In particular,clang-formatisn’t all that good on wrapping long lines, so I removed line length limit to avoid ugly continuation.Now, I don’t claim it is all pretty and nice now, but it’s much more consistent with both Minetest and itself.