Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed method declaration and implementation outside the class block #109

Merged
merged 3 commits into from
Nov 26, 2024
Merged

fixed method declaration and implementation outside the class block #109

merged 3 commits into from
Nov 26, 2024

Conversation

md-abid-hussain
Copy link
Contributor

closes #108

@mpacheco12
Copy link
Contributor

@md-abid-hussain Please fix conflicts

@md-abid-hussain
Copy link
Contributor Author

Sure

@md-abid-hussain
Copy link
Contributor Author

md-abid-hussain commented Nov 26, 2024 •
edited
Loading

@mpacheco12 Please review the changes.

There was already a method to remove the table but was implemented again with different name.

@mpacheco12 mpacheco12 merged commit 62a32c0 into mindsdb:main Nov 26, 2024
1 check passed
@mindsdb mindsdb locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mpacheco12 mpacheco12 mpacheco12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with table: Abstract Method and implementation Outside the Class
2 participants
@md-abid-hussain @mpacheco12