Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a DGL graph with create_dgl_graph function #5

Open
pgniewko opened this issue Jan 20, 2024 · 1 comment
Open

Creating a DGL graph with create_dgl_graph function #5

pgniewko opened this issue Jan 20, 2024 · 1 comment

Comments

@pgniewko
Copy link

pgniewko commented Jan 20, 2024

I've been looking into the code, and this line seems a bit puzzling (numerical experiments don't show any difference in the model's performance w/ and w/o this line). What is so special about the 'effect/phenotype' and why does it need to be set to 0? Isn't it replaced by a positive number anyways in the succeeding for loop? Are there any edge cases where even though the 'effect/phenotype' is not in the df, we still want to keep this node type in the graph?

@l4b4r4b4b4
Copy link

l4b4r4b4b4 commented Oct 3, 2024

exactly wondering about that Same loop. I did parallelize it, but it hangs at effect/phenotype 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants