Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine the datacoord meta related interfaces #37957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented Nov 23, 2024

issue: #35917
This PR refines the meta-related APIs in datacoord to allow the ctx to be passed down to the catalog operation interfaces

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tinswzy
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 23, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 23, 2024
Copy link
Contributor

mergify bot commented Nov 23, 2024

@tinswzy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@tinswzy tinswzy changed the title refine the datacoord meta related interfaces enhance: refine the datacoord meta related interfaces Nov 23, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 23, 2024
Copy link
Contributor

mergify bot commented Nov 23, 2024

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 89.96540% with 29 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (74752f2) to head (76fab9a).

Files with missing lines Patch % Lines
internal/datacoord/index_service.go 75.00% 0 Missing and 5 partials ⚠️
internal/datacoord/services.go 85.29% 2 Missing and 3 partials ⚠️
internal/datacoord/compaction.go 60.00% 4 Missing ⚠️
internal/datacoord/import_scheduler.go 82.35% 3 Missing ⚠️
internal/datacoord/compaction_task_meta.go 50.00% 0 Missing and 2 partials ⚠️
internal/datacoord/garbage_collector.go 71.42% 0 Missing and 2 partials ⚠️
internal/datacoord/meta.go 95.83% 0 Missing and 2 partials ⚠️
internal/datacoord/segment_manager.go 88.23% 0 Missing and 2 partials ⚠️
internal/datacoord/import_meta.go 96.00% 1 Missing ⚠️
internal/datacoord/partition_stats_meta.go 50.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37957       +/-   ##
===========================================
+ Coverage   68.87%   81.02%   +12.14%     
===========================================
  Files         289     1358     +1069     
  Lines       25481   190556   +165075     
===========================================
+ Hits        17551   154404   +136853     
- Misses       7930    30662    +22732     
- Partials        0     5490     +5490     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.19% <89.96%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/analyze_meta.go 100.00% <100.00%> (ø)
internal/datacoord/compaction_policy_clustering.go 75.59% <100.00%> (ø)
internal/datacoord/compaction_task_clustering.go 77.42% <100.00%> (ø)
internal/datacoord/compaction_task_l0.go 93.72% <100.00%> (ø)
internal/datacoord/compaction_task_mix.go 61.66% <100.00%> (ø)
internal/datacoord/compaction_trigger.go 85.13% <100.00%> (ø)
internal/datacoord/handler.go 75.30% <100.00%> (ø)
internal/datacoord/import_checker.go 84.51% <100.00%> (ø)
internal/datacoord/import_util.go 86.51% <100.00%> (ø)
internal/datacoord/index_meta.go 95.31% <100.00%> (ø)
... and 18 more

... and 1041 files with indirect coverage changes

---- 🚨 Try these New Features:

@congqixia
Copy link
Contributor

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants