Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm /zap #12

Merged
merged 2 commits into from
May 26, 2024
Merged

rm /zap #12

merged 2 commits into from
May 26, 2024

Conversation

mikhalytch
Copy link
Owner

@mikhalytch mikhalytch commented Sep 26, 2023

awaits uber-go/zap#1364 to be merged

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6a7538f) to head (58fa105).
Report is 12 commits behind head on main.

Current head 58fa105 differs from pull request most recent head c6f6a8d

Please upload reports for the commit c6f6a8d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        24   -10     
  Lines          364       305   -59     
=========================================
- Hits           364       305   -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhalytch mikhalytch force-pushed the rm_/zap branch 2 times, most recently from ceebc11 to 445a976 Compare May 26, 2024 22:23
@mikhalytch mikhalytch marked this pull request as ready for review May 26, 2024 22:38
Copy link
Owner Author

@mikhalytch mikhalytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikhalytch mikhalytch merged commit 5c38877 into main May 26, 2024
3 checks passed
@mikhalytch mikhalytch deleted the rm_/zap branch May 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant