Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-MacRoman archives for import #251

Open
mihaip opened this issue Nov 13, 2023 · 0 comments
Open

Add support for non-MacRoman archives for import #251

mihaip opened this issue Nov 13, 2023 · 0 comments

Comments

@mihaip
Copy link
Owner

mihaip commented Nov 13, 2023

I'd like to add https://macintoshgarden.org/apps/bluepaint (as mentioned by @gingerbreadman in #246 (comment)), it currently fails with:

  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/machfs/directory.py", line 92, in __setitem__
    raise ValueError('Could not encode key: %r' % key)
ValueError: Could not encode key: 'バージョン履歴'

The encoding at https://github.com/elliotnunn/machfs/blob/4f554286e6f5276a5b4d6d76f64fcecce31f1c26/machfs/directory.py#L88 is hardcoded as mac_roman. Though it may not be possible to do a mixed-encoding HFS volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant