Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citations without proper link #491

Open
grapheo12 opened this issue Aug 26, 2019 · 5 comments
Open

Citations without proper link #491

grapheo12 opened this issue Aug 26, 2019 · 5 comments
Labels
documentation 📚 help_wanted 💉 here you can help others or/and make pull requests

Comments

@grapheo12
Copy link

In the docs, the citation contains reference numbers which do not have proper links to the original papers.

@Rotzbua
Copy link
Collaborator

Rotzbua commented Aug 26, 2019

@grapheo12 Will you fix it? Or is this just a complain about a 5 year old document which looks like copy&paste?

@grapheo12
Copy link
Author

Surely! Just can you help me find the actual papers?

@Rotzbua Rotzbua added the help_wanted 💉 here you can help others or/and make pull requests label Aug 26, 2019
@leopold-gravier
Copy link
Contributor

Hello,
Here are replacement links for the broken ones in the documentation.

Ultralight :
https://www.nxp.com/docs/en/data-sheet/MF0ICU1.pdf

Ultralight C :
https://www.nxp.com/docs/en/data-sheet/MF0ICU2_SDS_32.pdf

I cannot do a pull request right now, but I'll try to do it in a couple of weeks.

Have a nice day,
Leopold

@Rotzbua
Copy link
Collaborator

Rotzbua commented Mar 11, 2024

@leopold-gravier I the issue creator refer to the word document which is kept for historic reason: https://github.com/miguelbalboa/rfid/blob/master/doc/rfidmifare.doc

@leopold-gravier
Copy link
Contributor

My bad.
Here's a backup of the wikipedia page that the documentation quotes : http://web.archive.org/web/20140225202826/https://en.wikipedia.org/wiki/MIFARE . The proper links can be found in the Reference tab.
Other thought : It may be wise to say explicitely that the doc is quoting wikipedia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📚 help_wanted 💉 here you can help others or/and make pull requests
Projects
None yet
Development

No branches or pull requests

3 participants