Skip to content
This repository has been archived by the owner on Nov 30, 2017. It is now read-only.

deleting static segment #37

Open
medy36 opened this issue Oct 14, 2014 · 6 comments
Open

deleting static segment #37

medy36 opened this issue Oct 14, 2014 · 6 comments
Labels
Milestone

Comments

@medy36
Copy link

medy36 commented Oct 14, 2014

am trying to add static segments (Winter/Summer), by using my own condition, am not used to MailChimp so i don't know if am doing things right. any feedback would be very useful Thanks.

@medy36
Copy link
Author

medy36 commented Oct 14, 2014

any body there ??

@miguel250
Copy link
Owner

@medy36 Here is the methods support for segment in v1 of the API. https://github.com/miguel250/MZMailChimpBundle/blob/master/Services/Methods/MCList.php#L245. Delete is not currently supported. It couple be added on the next version of the bundle/

@medy36
Copy link
Author

medy36 commented Oct 14, 2014

@miguel250 i proposed a modification in Services/Methods/MCList.php:
/**
* delete segment by Id
* @return bool
*/
public function listStaticSegmentDel($id)
{
$payload = array(
'id' => $this->listId,
);
$apiCall = 'staticSegmentDel'; // the problem is that this URL is incorrect
$result = $this->makeRequest($apiCall, $payload,$id);
return $result;
}

To use Segment very well we need to add other methods.

@miguel250 miguel250 added this to the v2 milestone Oct 14, 2014
@miguel250
Copy link
Owner

@medy36 I am okay with adding this change but as part of #34.

@medy36
Copy link
Author

medy36 commented Oct 22, 2014

@miguel250 can you please merge #39

@miguel250
Copy link
Owner

@medy36 I can't merge this because I am not taking any changes to the old API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants