[buildsystems] applocal.py incorrectly modifies the dynamic library name

[Hackerl]

Describe the bug
After installing dependencies with arm64-osx-dynamic triplet, the dynamic library name in the app bundle was incorrectly changed.

The first line displayed by otool -L should be the name of the dynamic library.

Environment

• OS: macos
• Compiler: clang

To Reproduce

1. Install libcurl using manifest mode with the arm64-osx-dynamic triplet and define the product as an app bundle:

add_executable(demo MACOSX_BUNDLE main.cpp)

2. After the build is complete and the app bundle is generated, vcpkg calls applocal.py to put the dependencies into the bundle.

I debugged applocal.py and printed relevant information.
I am confused about this line of code：

popen_args = ['install_name_tool', '-id', dep_rpath, binary]

The script executes the following command:

['install_name_tool', '-id', '@executable_path/../Frameworks/libz.1.3.1.dylib', '/Users/runner/terminal/build/terminal.app/Contents/Frameworks/libcurl-d.4.8.0.dylib']

According to the documentation of install_name_tool:

-id name
Changes the shared library identification name of a dynamic shared library to name. If the Mach-O binary is not a dynamic shared library and the -id option is
specified it is ignored.

Because the name was changed incorrectly, fixup_bundle did not work properly because it needs to do some logic based on the name.

I can't guess the purpose of executing "install_name_tool -id", it seems that there is no need to do this.