Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement onDismiss property for Modal in Fabric #13762

Open
danielayala94 opened this issue Sep 12, 2024 · 0 comments · May be fixed by #14126
Open

Implement onDismiss property for Modal in Fabric #13762

danielayala94 opened this issue Sep 12, 2024 · 0 comments · May be fixed by #14126
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: Modal Auto-filed: Batch 1 Auto-filed Issue filed via script using GitHub CLI enhancement Fabric: Do Not Implement UI props that mostly make sense in Android or iOS but not in Windows. Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.

Comments

@danielayala94
Copy link
Contributor

Implement the onDismiss property for Modal in RNW Fabric.

For reference, check the public API documentation: https://reactnative.dev/docs/modal#ondismiss-ios
@danielayala94 danielayala94 added API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: Modal Auto-filed Issue filed via script using GitHub CLI Auto-filed: Batch 1 enhancement Fabric: Do Not Implement UI props that mostly make sense in Android or iOS but not in Windows. labels Sep 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Sep 12, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 20, 2024
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 3, 2024
@TatianaKapos TatianaKapos linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: Modal Auto-filed: Batch 1 Auto-filed Issue filed via script using GitHub CLI enhancement Fabric: Do Not Implement UI props that mostly make sense in Android or iOS but not in Windows. Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
RNW New Architecture
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fabric] Implement onDismiss for Modal and remove titlebar TatianaKapos/react-native-windows
3 participants
@danielayala94 @chrisglein @chiaramooney