-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xunit): support netstandard2.0 #3063
Conversation
{ | ||
private static readonly ConcurrentStack<Worker> _allWorkers = new(); | ||
private Worker? _currentWorker = null!; | ||
private Worker _currentWorker = null!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by: Similar to 7f3b888.
e3c8e56
to
e89982e
Compare
How about targeting netstandard instead? |
|
e89982e
to
2d719cc
Compare
I didn't do it because of:
Since removing #3063 (comment) sounds good to me we can target
Addressed. Thanks both! |
ModuleInitializer
was something which was not supported in older .NET frameworks. This patch starts listening on the constructor instead and resets the TestOK status in TestInitialize.Background: xUnit 2 does not provide a reliable way of determining if a test was passing or failing and reading it's status in the AfterEach. xUnit 3 allows to read its status which we'll use once its published. We want to support xUnit 2 as well.
#2977