Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is wrong for Page.WaitFor functions #2469

Open
mpelley opened this issue Jan 27, 2023 · 1 comment
Open

Documentation is wrong for Page.WaitFor functions #2469

mpelley opened this issue Jan 27, 2023 · 1 comment

Comments

@mpelley
Copy link

mpelley commented Jan 27, 2023

The documentation for the various WaitFor functions seems to be a copy of the associated RunAndWaitFor function. See https://playwright.dev/dotnet/docs/api/class-page. The documentation describes performing the action. The documentation has an action parameter. Only the RunAndWaitFor functions have the action parameter.

@Mammoets
Copy link
Contributor

I noticed that this issue has been open for a while, and I'd like to help move it forward.

I've reviewed the documentation for the various WaitFor*Async and RunAndWaitFor*Async methods, and it seems the problem is still present. The summaries and usage examples are largely the same, even though the behaviors differ between these methods.

@mxschmitt, I noticed you added the "P3-collecting-feedback" label some time ago. I'd be happy to open a pull request to correct these issues if that's helpful. Please let me know if there's any specific guidance or feedback you'd like me to consider when making these updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants