Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“SIGINT - custom in parent and child” is flaky on Linux (possibly need slow CPU to reproduce) #715

Open
brjsp opened this issue Sep 13, 2024 · 0 comments

Comments

@brjsp
Copy link

brjsp commented Sep 13, 2024

Environment details

  • OS: Linux (various Fedora and openSUSE)
  • node-pty version: 1.1.0-beta21 (as shipped in vscode)
  • node.js version: Electron 30.x with ELECTRON_RUN_AS_NODE

Issue description

  18 passing (13s)
  1 failing

  1) UnixTerminal
       signals in parent and child
         SIGINT - custom in parent and child:

      Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

      + expected - actual

      -false
      +true
      
      at ChildProcess.<anonymous> (lib/unixTerminal.test.js:171:28)
      at ChildProcess.emit (node:events:519:28)
      at maybeClose (node:internal/child_process:1105:16)
      at ChildProcess._handle.onexit (node:internal/child_process:305:5)

We've observed this test occasionally failing on aarch64, arm and riscv64, but never on x86_64. (This is possibly due to our x86_64 machines being fast)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant