Enable Debugger By Default in Q35/SBSA #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
kuqin12
approved these changes
Sep 13, 2024
cfernald
reviewed
Sep 13, 2024
cfernald
reviewed
Sep 13, 2024
cfernald
approved these changes
Sep 17, 2024
apop5
approved these changes
Sep 19, 2024
makubacki
approved these changes
Sep 24, 2024
os-d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR turns mu_feature_debugger on by default in Q35/SBSA. It sets no initial breakpoint, but will break in on an exception. As part of this, QemuRunner defaults to having
SERIAL_PORT=50001if this is not overridden, so that on a regular boot of Q35 the debugger can easily be used. On SBSA, the serial port is not added by default, as it will prevent writing to stdout, making it hard to tell progress.An additional command line flag is added
BLD_*_DXE_DBG_BRKto control whether the initial breakpoint is set. PassingBLD_*_DXE_DBG_BRK=TRUEon the commandline will set an unlimited initial breakpoint on DxeCore entrance.The other caveat in SBSA is that with a single serial port, debugger polling is disabled, otherwise the debugger can eat user keystrokes at the shell.
Once supervised StMM support is added to mu_feature_debugger (microsoft/mu_feature_debugger#59), it will be added here with a corresponding flag to force breaking in to the MM debugger.
How This Was Tested
Tested by booting Q35 with no exceptions, with an exception and breaking in, and with the force flag and breaking in on initial breakpoint.
Integration Instructions
See above.