[DataGrid] Alter rendering to use table elements #2664
+1,052
−909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adapt more samples to table rendering - Undo Tabs example changes - Remove grid custom events from script etc
- Clean up CSS, commented code/apply code styles - revert `.col-header` rename (back to `.column-header) to have less breaking changes - Fix some samples
- Fix resize reset - Make size related methods public - Make GridTemplateColumns work again
- Take resize handler out of button
-Update RemoveSortByColumn logic
- Add `MultiLine` parameter to grid + styling - Make `AutoSize` work again
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
vnbaaij
changed the title
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 60.7%
|
dvoituron
requested changes
Sep 17, 2024
- Set `RowSize` to small to be equal to v4 default
- Process review comments
- Fix some samples - Position resize handle better - Always put sort/filter indicators behind header text - Add comments to public methods
vnbaaij
changed the title
…d our default (24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
All work is done but some changes might be made based on the discussion in #2667
I'm swapping out the web components for standard HTML table elements. Reasons for doing this:
Because of some HTML/CSS trickery, it is still possible to use the
GridTemplateColumnsparameter on the grid or theWidthproperty on the columns to set column widths.There are going to be some breaking changes with this...
The option to choose between using the new way of adding column actions (introduced in 4.10) or doing it the previous way, will disappear. The new way will be the standard moving forward. This is done because of code maintenance reasons but also because we achieve much better accessibility with this.The option to choose is still availableMultiLine(bool) parameter of theFluentDataGrid. Previously this could be done by setting aRowClasson a column but that does not work anymore