Add decoder compatibility argument #20687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismayilov-ismayil
added
enhancement
Area: ABTT
7 tasks
| @@ -120,6 +120,11 @@ function sevenZipArchive(archive: string, compression: string, files: string[]) | |||
| sevenZip.arg('-mx=' + mapSevenZipCompressionLevel(sevenZipCompression)); | |||
| } | |||
|
|
|||
| const decoderCompatibility = tl.getInput('decoderCompatibility', false); | |||
| if (win && decoderCompatibility && archiveType == '7z') { | |||
There was a problem hiding this comment.
By the PR description, should it be !win os something else as it's only for linux?
There was a problem hiding this comment.
linux uses old version to archive and extract, but windows uses new version decoder for both.
if we archive on windows (new) and extract on linux (old version) it fails.
thus, we provide new param on windows only (new version 7z), old versions (linux) doesn't have this argument
vmapetr
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: ArchiveFilesV2
Description: After upgrading 7zip to v2408 the compressed files are not compatible with older versions of 7zip (on linux).
Added new argument to make it compatible with older versions extracting.
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y
Checklist: