Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Consider making it possible for a MidiEndpointConnection to be automatically reconnected after a device has disconnected/reconnected #320

Open
Psychlist1972 opened this issue Apr 18, 2024 · 5 comments
Assignees
Labels
area-sdk 🔧 Related to the application SDK feature :shipit: Approved feature on the official backlog

Comments

@Psychlist1972
Copy link
Contributor

Psychlist1972 commented Apr 18, 2024

If a device is disconnected and reconnected, currently, the API requires creating a new connection, or at least re-opening the existing connection. But in cases where this happens due to something transient like putting the PC into suspend mode, the device cannot be reconnected without creating a new connection instance through the MidiSession.

Consider providing a way to easily reconnect automatically when a device reappears (API would control) as long as the MidiEndpointConnection instance exists.

@Psychlist1972 Psychlist1972 added feature request 💡 New feature request or proposal area-service-or-api 🖥️ Related to the Windows Service, core API, abstractions, etc. needs-investigation 🔍 Needs to be investigated before considering or solving. labels Apr 18, 2024
@Psychlist1972 Psychlist1972 self-assigned this Apr 18, 2024
@Psychlist1972 Psychlist1972 changed the title [Feature] Consider making it possible for a MidiEndpointConnection to be reconnected after a device has disconnected [Feature] Consider making it possible for a MidiEndpointConnection to be automatically reconnected after a device has disconnected/reconnected Apr 19, 2024
@Psychlist1972
Copy link
Contributor Author

This will be implemented in Developer Preview 6

@Psychlist1972 Psychlist1972 added area-sdk 🔧 Related to the application SDK dp6-fixed 🥳 Fixed/implemented in Developer Preview 6 and removed area-service-or-api 🖥️ Related to the Windows Service, core API, abstractions, etc. labels May 22, 2024
@Psychlist1972 Psychlist1972 moved this to 💻 Complete in Windows MIDI Services May 22, 2024
@Psychlist1972 Psychlist1972 added feature :shipit: Approved feature on the official backlog and removed feature request 💡 New feature request or proposal needs-investigation 🔍 Needs to be investigated before considering or solving. labels May 23, 2024
@Psychlist1972
Copy link
Contributor Author

Keeping this open due to bug reports of it not working in DP6.

@Psychlist1972
Copy link
Contributor Author

Issue #360 is the related issue

@Psychlist1972 Psychlist1972 removed the dp6-fixed 🥳 Fixed/implemented in Developer Preview 6 label Oct 31, 2024
@Psychlist1972
Copy link
Contributor Author

Still working on this, FYI.

@MusicMaker
Copy link

Should this callback be added using the watcher ? Currently DP6 code for the watcher does not have a property for this. Something alike
auto revokeOnWatcherDeviceReconnected = watcher.Reconnected(OnWatcherDeviceReconnected);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sdk 🔧 Related to the application SDK feature :shipit: Approved feature on the official backlog
Projects
Status: 💻 Complete
Development

No branches or pull requests

2 participants