Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnet process is spawned multiple times #570

Open
dotai2012 opened this issue Jul 18, 2023 · 3 comments
Open

Dotnet process is spawned multiple times #570

dotai2012 opened this issue Jul 18, 2023 · 3 comments
Labels

Comments

@dotai2012
Copy link

dotai2012 commented Jul 18, 2023

To Reproduce
Steps to reproduce the behavior:

  1. Open Vscode
  2. Close the program
  3. Open Task Manager and check for the Dotnet process
  4. Back to step 1, every time I open Vscode, it spawns a new one

Expected behavior
When closing Vscode, dotnet should exit as well

Screenshots
image
image

Versions(please complete the following information):

  • OS: Ubuntu 22.04
  • Devskim Version: 1.0.11
@dotai2012 dotai2012 added the bug label Jul 18, 2023
@gfs
Copy link
Contributor

gfs commented Jul 24, 2023

Hello @dotai2012,

I've attempted to replicate this but am not seeing this behavior with DevSkim 1.0.11 on Windows, the .NET process appears to properly quit when VS Code is closed. I'll attempt to replicate today on Ubuntu.

@gfs
Copy link
Contributor

gfs commented Jul 24, 2023

I'm able to replicate this on Ubuntu, but am not yet sure how to resolve it. The design of the extension delegates responsibility for the lifecycle of the Language Server process to the VS Code library for the Language Client which launches and then connects to the server. Its not clear why it would properly close the processes on Windows but not on Ubuntu but will investigate more.

@gfs
Copy link
Contributor

gfs commented Jul 24, 2023

This issue doesn't appear to be present in Bicep which uses a very similar design including also using the omnisharp language server library, which may be useful as a reference to identify the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants