Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metalog decomposition: Logger, Formatter, Console #208

Closed
wants to merge 23 commits into from
Closed

Metalog decomposition: Logger, Formatter, Console #208

wants to merge 23 commits into from

Conversation

georgolden
Copy link
Member

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

@georgolden
Copy link
Member Author

#203

#202

tshemsedinov
tshemsedinov reviewed Aug 23, 2022
View reviewed changes
lib/console.js Outdated Show resolved Hide resolved
lib/console.js Outdated Show resolved Hide resolved
lib/console.js Outdated Show resolved Hide resolved
lib/console.js Outdated Show resolved Hide resolved
lib/formatter.js Outdated Show resolved Hide resolved
@tshemsedinov tshemsedinov changed the title Metalog decomposition, new Logger implementation with DI, multiple loggers support Metalog decomposition: Logger, Formatter, Console Aug 23, 2022
tshemsedinov
tshemsedinov reviewed Aug 25, 2022
View reviewed changes
lib/console.js Show resolved Hide resolved
lib/formatter.js Outdated Show resolved Hide resolved
lib/formatter.js Outdated Show resolved Hide resolved
lib/formatter.js Outdated Show resolved Hide resolved
lib/formatter.js Outdated Show resolved Hide resolved
lib/fsLogger.js Outdated Show resolved Hide resolved
lib/fsLogger.js Outdated Show resolved Hide resolved
lib/fsLogger.js Outdated Show resolved Hide resolved
lib/fsLogger.js Outdated Show resolved Hide resolved
lib/fsLogger.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Aug 25, 2022
View reviewed changes
lib/formatter.js Outdated Show resolved Hide resolved
tshemsedinov
tshemsedinov reviewed Aug 25, 2022
View reviewed changes
lib/formatter.js Outdated Show resolved Hide resolved
@tshemsedinov
Copy link
Member

Outdated as well as #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phewphewb phewphewb phewphewb left review comments

@tshemsedinov tshemsedinov Awaiting requested review from tshemsedinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgolden @tshemsedinov @phewphewb