Implement identification primitives #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
approved these changes
Dec 17, 2018
lib/identification.js
Outdated
| this.host = host; | ||
| this.ports = ports; | ||
| if (this.ports.length > 1) { | ||
| this.ports = sequence(this.ports, 0); |
There was a problem hiding this comment.
this.ports = ports.length > 1 ? sequence(this.ports, 0) : ports
lib/identification.js
Outdated
| return [arrayifyTree(node[0]), arrayifyTree(node[1])]; | ||
| } else { | ||
| return node; | ||
| } |
lundibundi
approved these changes
Dec 20, 2018
|
|
||
| const contains = (test, object, expected) => { | ||
| for (const key in expected) { | ||
| if (!expected.hasOwnProperty(key)) { |
There was a problem hiding this comment.
I'd prefer Object.keys instead of manual checking properties here.
lundibundi
approved these changes
Dec 20, 2018
|
Ping @nechaido, @tshemsedinov. |
nechaido
approved these changes
Jan 3, 2019
|
ping @tshemsedinov |
tshemsedinov
approved these changes
Jan 8, 2019
Refs: #8 Refs: metarhia/Metarhia#21 PR-URL: #304
PR-URL: #304 Co-authored-by: Mykola Bilochub <[email protected]>
belochub
force-pushed
the
identification
branch
from
a67d9dc
to
6f8d80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8
Refs: metarhia/Metarhia#21