pager.html: stay on the same page #2223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a result with 10 per page, the second page starts at 10 On a result with 100 per page, the second page starts at 100 As long as you landed on the page from a search result the link shouldn't take you past the end of the results.
|
Thanks for this. I wonder why we don't just use a pagination module here? |
|
The pagination plugin doesn't have support for changing page size. Edit: while looking at this area, it might be nice to spend some time pondering on #1686 |
|
I'm ok with not using a plugin if it makes things easier. |
|
#1476 is related too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a result with 10 per page, the second page starts at 10
On a result with 100 per page, the second page starts at 100
As long as you landed on the page from a search result the link shouldn't take you past the end of the results.
Completely untested fix for #2218