Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more modular parser class #24

Open
rwstauner opened this issue Sep 14, 2014 · 2 comments
Open

A more modular parser class #24

rwstauner opened this issue Sep 14, 2014 · 2 comments

Comments

@rwstauner
Copy link

Would you be open to a pull request that broke load_string into a CPAN::Changes::Parser class with several methods?
Something that would be easier to subclass in case there are times where a custom (non-spec-conforming) parser may be desired?

For example, separate methods for detecting matching lines for versions and groups
as well as handling them would allow a lot more flexibility (and also make unit testing easier, etc).

@bricas
Copy link
Contributor

bricas commented Sep 14, 2014

Sounds lovely! :)

@rwstauner
Copy link
Author

Great. Not making any promises, but wanted to ask before assuming you'd want a big change like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants