Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate pricing entities to DML models #10335

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

refactor: migrate pricing entities to DML models #10335

wants to merge 12 commits into from

Conversation

thetutlage
Copy link
Contributor

Fixes: FRMW-2810

@thetutlage thetutlage requested a review from a team as a code owner November 28, 2024 07:00
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bbcd8e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 1:08pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 29, 2024 1:08pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 1:08pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 1:08pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 1:08pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 1:08pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 1:08pm

thetutlage
thetutlage commented Nov 29, 2024
View reviewed changes
packages/modules/pricing/src/models/price.ts
},
])

Price.name = "Price" as any
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model name is converted to price via DML which under the uses the toCamelCase util and our toCamelCase util ain't correct 🤣

Copy link
Member

@adrien2p adrien2p Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the DML and the name of the mikro orm entity can be different in casing, for the mikro orm entity we apply specific conversion, and the idea is that any adapter can get from the base casing and case it has they need for the underlying tec they are using. In the repositories we can just use this.entity.name or this.entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thetutlage @adrien2p