fix: Handle region updates on cart (1/n) #9369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
olivermrbl
commented
Oct 1, 2024
| @@ -316,6 +316,49 @@ medusaIntegrationTestRunner({ | |||
| ) | |||
There was a problem hiding this comment.
These are all tests of the HTTP layer, so I'll move these to integration-tests/http before merging. Keeping them as is, because the diff would otherwise be off
olivermrbl
force-pushed
the
fix/update-region-on-cart
branch
from
4fd1016
to
f26552f
Compare
olivermrbl
changed the title
olivermrbl
requested review from
sradevski,
adrien2p,
kasperkristensen and
srindom
olivermrbl
force-pushed
the
fix/update-region-on-cart
branch
from
60096d9
to
77956ae
Compare
sradevski
reviewed
Oct 2, 2024
carlos-r-l-rodrigues
approved these changes
Oct 4, 2024
Co-authored-by: Carlos R. L. Rodrigues <[email protected]>
riqwan
approved these changes
Oct 4, 2024
Comment on lines
+320
to
+324
| const region = await regionModule.createRegions({ | ||
| name: "US", | ||
| currency_code: "usd", | ||
| countries: ["us"], | ||
| }) |
There was a problem hiding this comment.
Suggested change
| const region = await regionModule.createRegions({ | |
| name: "US", | |
| currency_code: "usd", | |
| countries: ["us"], | |
| }) | |
| const region = (await api.post( | |
| `/admin/regions`, | |
| { | |
| name: "US", | |
| currency_code: "usd", | |
| countries: ["us"], | |
| }, | |
| adminHeaders | |
| )).data.region |
Comment on lines
+799
to
803
| const region = await regionModule.createRegions({ | ||
| name: "US", | ||
| currency_code: "usd", | ||
| automatic_taxes: false, | ||
| }) |
There was a problem hiding this comment.
Suggested change
| const region = await regionModule.createRegions({ | |
| name: "US", | |
| currency_code: "usd", | |
| automatic_taxes: false, | |
| }) | |
| const region = (await api.post( | |
| `/admin/regions`, | |
| { | |
| name: "US", | |
| currency_code: "usd", | |
| automatic_taxes: false | |
| }, | |
| adminHeaders | |
| )).data.region |
panalgin
pushed a commit
to vennyx-org/medusa
that referenced
this pull request
Oct 7, 2024
**What**
On cart creation:
- If region only has one country -> create cart with country code
On cart updates:
- If shipping address country code is provided in input ->
- If cart region doesn't include that country -> throw
- If cart includes the country -> update shipping address
- If region is provided in input and is different from the one currently on the cart ->
- If there is a shipping address on the cart -> clear the address
- If the region only has one country -> set country code of address
- If there is not a shipping address on the cart ->
- If the region only has one country -> set country code of address
Closes CC-545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On cart creation:
On cart updates:
Closes CC-545