Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa,core-flows,types,js-sdk): decline / cancel order transfer #10202

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

feat(medusa,core-flows,types,js-sdk): decline / cancel order transfer #10202

wants to merge 20 commits into from

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Nov 21, 2024

What

  • core-flows:
    • cancel transfer
    • decline transfer
  • API:
    • admin cancel transfer
    • store decline transfer
    • store cancel transfer
  • js-sdk:
    • add methods for store endpoints

CLOSES CMRC-726

@fPolic fPolic requested a review from a team as a code owner November 21, 2024 13:18
@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 3:27pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 24, 2024 3:27pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 3:27pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 3:27pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 3:27pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 3:27pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 3:27pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6739741

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

riqwan
riqwan approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments/suggestions, overall lgtm!

integration-tests/http/__tests__/order/admin/transfer-flow.spec.ts Show resolved Hide resolved
integration-tests/http/__tests__/order/admin/transfer-flow.spec.ts Outdated Show resolved Hide resolved
integration-tests/http/__tests__/order/admin/transfer-flow.spec.ts Show resolved Hide resolved
packages/core/core-flows/src/order/workflows/transfer/cancel-order-transfer.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/order/workflows/transfer/cancel-order-transfer.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/order/workflows/transfer/cancel-order-transfer.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/order/workflows/transfer/decline-order-transfer.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/order/workflows/transfer/decline-order-transfer.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/admin/orders/[id]/transfer/cancel/route.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/store/orders/middlewares.ts Show resolved Hide resolved
@fPolic
Copy link
Contributor Author

fPolic commented Nov 24, 2024

/snapshot-this

@github-actions GitHub Actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 96b8963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl left review comments

@riqwan riqwan riqwan approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fPolic @riqwan @olivermrbl