Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#7375): service worker auto update #9417

Merged
merged 37 commits into from
Nov 6, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Sep 6, 2024

Description

Show the reload modal even when the service worker updates automatically in the background due to browser internals.

#7375

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

…-auto-update

# Conflicts:
#	webapp/tests/karma/ts/app.component.spec.ts
…-auto-update

# Conflicts:
#	tests/page-objects/default/common/common.wdio.page.js
#	webapp/tests/karma/ts/app.component.spec.ts
…ervice-worker-auto-update

# Conflicts:
#	tests/e2e/default/transitions/create-user-for-contacts.replace-user.wdio-spec.js
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready! 🚀 🌕

Copy link
Contributor

@tatilepizs tatilepizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Diana 🚀

@dianabarsan dianabarsan merged commit 6876239 into master Nov 6, 2024
45 checks passed
@dianabarsan dianabarsan deleted the 7375-service-worker-auto-update branch November 6, 2024 19:51
kapelo pushed a commit that referenced this pull request Nov 7, 2024
Show the reload modal even when the service worker updates automatically in the background due to browser internals.
sugat009 pushed a commit that referenced this pull request Nov 18, 2024
Show the reload modal even when the service worker updates automatically in the background due to browser internals.

#7375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants