Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add nepali translations and remove unused keys #9219

Merged
merged 27 commits into from
Aug 31, 2024

Conversation

1yuv
Copy link
Member

@1yuv 1yuv commented Jun 28, 2024

Description

This PR addresses multiple issues and addresses some translation fixes.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@1yuv 1yuv marked this pull request as draft June 28, 2024 09:42
Copy link
Member

@binokaryg binokaryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some translations and requested some changes.

api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
@1yuv 1yuv requested a review from garethbowen August 27, 2024 13:47
@1yuv 1yuv requested a review from garethbowen August 28, 2024 11:36
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions inline.

api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
@1yuv 1yuv marked this pull request as ready for review August 28, 2024 12:09
@1yuv 1yuv changed the title chore: nepali translations 200-800 chore: nepali translations and remov unused keys Aug 29, 2024
@1yuv 1yuv changed the title chore: nepali translations and remov unused keys chore: nepali translations and remove unused keys Aug 29, 2024
Copy link
Member

@binokaryg binokaryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions until line 105.

api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
Comment on lines 100 to 101
Error\ sending\ message = सन्देश पठाउनमा त्रुटी
Error\ updating\ contact = सम्पर्क परिमार्जनमा त्रुटी
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Error\ sending\ message = सन्देश पठाउनमा त्रुटी
Error\ updating\ contact = सम्पर्क परिमार्जनमा त्रुटी
Error\ sending\ message = सन्देश पठाउनमा त्रुटि
Error\ updating\ contact = सम्पर्क परिमार्जनमा त्रुटि

Comment on lines 102 to 105
Error\ updating\ facility = संस्था परिमार्जन गर्दा त्रुटी
Error\ updating\ group = समूह परिमार्जन गर्नेमा त्रुटी
Error\ updating\ user = प्रयोगकर्ता परिमार्जन गर्नेमा त्रुटी
Errors = त्रुटीहरू
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Error\ updating\ facility = संस्था परिमार्जन गर्दा त्रुटी
Error\ updating\ group = समूह परिमार्जन गर्नेमा त्रुटी
Error\ updating\ user = प्रयोगकर्ता परिमार्जन गर्नेमा त्रुटी
Errors = त्रुटीहरू
Error\ updating\ facility = संस्था परिमार्जन गर्दा त्रुटि
Error\ updating\ group = समूह परिमार्जन गर्नेमा त्रुटि
Error\ updating\ user = प्रयोगकर्ता परिमार्जन गर्नेमा त्रुटि
Errors = त्रुटिहरू

Copy link
Member

@binokaryg binokaryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More changes requested.

Does every : require escaping (\:)? If so, we have missed to escape many such texts.

People = व्यक्तिहरू
Person = व्यक्ति
Phone = फोन
Phone\ Number = फोन नम्बर
Phone\ number\ conversion = फोन नं रुपान्तरण
Phone\ number\ example = आवश्यक परेमा कन्ट्री कोड थपिने छ। उदाहरणको लागि ९८२६१३१०० वा +९७७९८२६१३१००
Phone\ number\ not\ valid = फोन नं अमान्य
Places = ठाउँ/स्थान हरू
Places = स्थान/स्थान हरू
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Places = स्थान/स्थान हरू
Places = स्थानहरू

This\ message\ is\ part\ of\ group = यो सन्देश एउटा समुहको अंश हो
The\ group\ must\ be\ an\ integer = समूह पूर्ण अङ्क हुनैपर्छ
The\ offset\ unit\ must\ be\ an\ integer = अफसेट पूर्ण अङ्क हुनैपर्छ
The\ unit\ must\ be\ an\ integer = ईकाई पूर्ण अङ्क हुनैपर्छ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The\ unit\ must\ be\ an\ integer = ईकाई पूर्ण अङ्क हुनैपर्छ
The\ unit\ must\ be\ an\ integer = एकाइ पूर्ण अङ्क हुनैपर्छ

To\ Phone = पाउने फोन
Translation\ file = अनुबाद फाइल
Translation\ file\ help = यो भाषा लागि अनुवाद प्रतिस्थापन गर्न आयात गर्न .प्रॉपर्टीस फाइल चयन गर्नुहोस्। सही ढाँचामा फाइल उत्पन्न गर्न सजिलो बाटो त आयात , यो भाषा लागि अनुवाद निर्यात कुनै संशोधन गर्न छ ।
Translations = अनुबादन
Translation\ file\ help = यो भाषा लागि अनुवाद प्रतिस्थापन गर्न आयात गर्न .properties फाइल चयन गर्नुहोस्। सही ढाँचामा फाइल उत्पन्न गर्न सजिलो बाटो यसलाई निर्यात गरि , आवश्यक परिवर्तन गरेर पुन:आयात गर्नु हो।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Translation\ file\ help = यो भाषा लागि अनुवाद प्रतिस्थापन गर्न आयात गर्न .properties फाइल चयन गर्नुहोस्। सही ढाँचामा फाइल उत्पन्न गर्न सजिलो बाटो यसलाई निर्यात गरि , आवश्यक परिवर्तन गरेर पुन:आयात गर्नु हो।
Translation\ file\ help = यो भाषाका लागि अनुवाद प्रतिस्थापन गर्न वा आयात गर्न .properties फाइल चयन गर्नुहोस्। सही ढाँचामा फाइल उत्पन्न गर्न सजिलो बाटो यसलाई निर्यात गरी , आवश्यक परिवर्तन गरेर पुन: आयात गर्नु हो।

Unread\ below = पढ्न बाँकी सन्देश तल
Unsaved\ changes = बचत नभएका परिवर्तनहरू
Unverified = रुजु नगरिएको
Unverify = रुजु नगर्न
Update = अद्यावधिक
Update\ Facility = संस्था परिमार्जन
Upload\ Forms =
Upload\ Forms = फर्म अपलोड गर्नुहोस्
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For form, we have used फर्म 13 times, and फारम 21 times.
We need to make them consistent, later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

धन्यवाद। फर्म प्रयोग गर्ने।

@@ -279,34 +279,35 @@ Visits = स्वाथ्य संस्थामा जाँच
Weeks\ Pregnant = गर्भवती भएको हप्ता
_id = रेकर्ड UUID
about = बारे
about.cht = Powered by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Powered by X would be X द्वारा संचालित

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will read as द्वारा संचालित X if we translate, so I left as this.

api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
api/resources/translations/messages-ne.properties Outdated Show resolved Hide resolved
users.import.summary.resubmit.step3 = ३. त्रुटिहरू सच्याउनुहोस् र .csv मा निर्यात गर्नुहोस्
users.import.summary.resubmit.step4 = ४. अपडेट गरिएको स्प्रेडशीट पुनः अपलोड गर्नुहोस्
users.import.title = प्रयोगकर्ता आयात शीर्षक
users.import.unavailable.instructions = अनुपलब्ध निर्देशनहरू
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
users.import.unavailable.instructions = अनुपलब्ध निर्देशनहरू
users.import.unavailable.instructions = प्रणालीमा अरू कोही हाल प्रयोगकर्ताहरू थप्ने प्रक्रियामा छन्।

users.import.title = प्रयोगकर्ता आयात शीर्षक
users.import.unavailable.instructions = अनुपलब्ध निर्देशनहरू
users.import.unavailable.retry = पुन: प्रयास गर्नुहोस्
users.import.unavailable.title = अनुपलब्ध शीर्षक
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
users.import.unavailable.title = अनुपलब्ध शीर्षक
users.import.unavailable.title = उपलब्ध छैन

users.import.unavailable.instructions = अनुपलब्ध निर्देशनहरू
users.import.unavailable.retry = पुन: प्रयास गर्नुहोस्
users.import.unavailable.title = अनुपलब्ध शीर्षक
users.import.upload_button = अपलोड बटन
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
users.import.upload_button = अपलोड बटन
users.import.upload_button = अपलोड .csv

1yuv and others added 2 commits August 30, 2024 10:15
Apply suggestions from code review

Co-authored-by: Binod Adhikary <[email protected]>
@1yuv 1yuv requested a review from binokaryg August 30, 2024 06:03
Copy link
Member

@binokaryg binokaryg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on the translations. This is a significant task, and your efforts will have a lasting impact.

@1yuv 1yuv merged commit 94ac934 into master Aug 31, 2024
44 checks passed
@1yuv 1yuv deleted the ne_translations_201_800 branch August 31, 2024 07:04
@Benmuiruri Benmuiruri changed the title chore: nepali translations and remove unused keys chore: add nepali translations and remove unused keys Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants