ally.maintain.tabFocus breaks tab in Android + Chrome

[ZoeBijl]

When focus is trapped with ally.maintain.tabFocus it breaks the tab key on Android + Chrome when used in combination with a bluetooth keyboard.

Android v7.1.1
Used ally.js from https://cdn.jsdelivr.net/ally.js/1.4.1/ally.min.js

Added my test case as HTML:
issue-3-advice.html.zip

This is also true for the example located at: https://allyjs.io/tutorials/dialog.example.html

[rodneyrehm]

Hey @MichielBijl, sorry for the the delay! What exactly does "breaks the tab key" mean?

I don't have an Android 7.1 device and BT keyboard to reproduce, so any detail you can share to understand the problem helps :)

[mikem201486]

https://allyjs.io/tutorials/dialog.example.html

[mikem201486]

issue-3-advice.html.zip

[mikem201486]

https://cdn.jsdelivr.net/ally.js/1.4.1/ally.min.js

[rodneyrehm]

Sorry for the (insanely) long wait… I'm afraid this is due to the fact that I've never been able to get "keyboard tabbing" to work in any of my Android devices. That's why Focusable Elements - Browser Compatibility Table does not consider any element keyboard focusable ("tabbable") on Android. That has been coded into src/is/tabbable.js and is now causing the described problem with ally.maintain.tabFocus.

To solve this I'll have to obtain a modern android device with bluetooth keyboard, rerun the tests and update the filters accordingly. Unfortunately this will take a while.

[ZoeBijl]

I might be able to retest this in our test lab.