Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove strategy: "quick" from ally.query.focusable et al #132

Open
rodneyrehm opened this issue Mar 28, 2016 · 0 comments
Open

remove strategy: "quick" from ally.query.focusable et al #132

rodneyrehm opened this issue Mar 28, 2016 · 0 comments

Comments

@rodneyrehm
Copy link
Member

As of ally.js 1.1.0 the "quick" strategy (using document.querySelectorAll()) still is the default strategy, even though its accuracy is well below the "strict" strategy (using TreeWalker). The reason for keeping qSA approach was selector performance, but it looks as if it isn't all that much faster.

I'd like to remove this option to simplify the docs and the code base:

Any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant